Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor start and stop functionality of the simulator #239

Open
5 tasks done
Tracked by #75
georgi-l95 opened this issue Oct 9, 2024 · 0 comments · May be fixed by #307
Open
5 tasks done
Tracked by #75

Refactor start and stop functionality of the simulator #239

georgi-l95 opened this issue Oct 9, 2024 · 0 comments · May be fixed by #307
Assignees
Labels
Improvement Code changes driven by non business requirements Simulator Issue related to Block Stream Simulator
Milestone

Comments

@georgi-l95
Copy link
Contributor

georgi-l95 commented Oct 9, 2024

Problem

Currently stop method does nothing else, apart from setting a variable to false.
Start method Only initiates a while loop and start streaming already loaded data.

Solution

  • Stop method should stop the streaming or consuming
  • Start method should start streaming or consuming (depending on configuration)
    • Extract current publisher logic in outside method
    • Extract future consumer logic in outside method
  • Start method should actually, depending on configuration, setup the channel, otherwise it produces errors.

Alternatives

No response

@georgi-l95 georgi-l95 added the Simulator Issue related to Block Stream Simulator label Oct 9, 2024
@georgi-l95 georgi-l95 added this to the 0.1.0 milestone Oct 9, 2024
@georgi-l95 georgi-l95 self-assigned this Oct 9, 2024
@AlfredoG87 AlfredoG87 modified the milestones: 0.1.0, 0.2.0 Oct 12, 2024
@georgi-l95 georgi-l95 added the Improvement Code changes driven by non business requirements label Oct 14, 2024
@georgi-l95 georgi-l95 linked a pull request Oct 21, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment