HIP 336 - Approval and Allowance API for Tokens

[superboo]

Discuss HIP-336 - Approval and Allowance API for Tokens

#336

[bugbytesinc]

Why is it necessary to specify Owner when it is redundant because it can only be the Payer/operator of the transaction?

https://github.com/hashgraph/hedera-protobufs/blob/77685bd9ef73302feff040a4c05605c863adecb0/services/response_code.proto#L1205

[mohsin-hedera]

Thanks for pointing this out. This has since been deprecated.

[hashaxis]

As a marketplace, token allowances are a superior solution to an escrow method.

However:

“Each account is limited to 100 allowances. This limit spans hbar and fungible token allowances and non-fungible token approved_for_all grants. There is no limit on the number of NFT serial number approvals an owner may grant.”

The arbitrary limit of 100 allowances creates a similar issue for a marketplace which the arbitrary limit of token associations created:

Which is that we’d need to create many unnecessary accounts just to scale our ability to list tokens if implementing this.

The limit on token associations was removed which allowed us to scale without creating unnecessary accounts. We would suggest that this 100 allowance limit is scaled to at least 10,000 or removed entirely if feasible.

[hashaxis]

@Ashe-Oro

"There is no limit on the number of NFT serial number approvals an owner may grant.” -- Give is unlimited.

"Each account is limited to 100 allowances." -- Receive is limited to 100.

[Ashe-Oro]

NFT serial number = 0.0.1043046/1 (unlimited)
NFT collection = 0.0.1043046 (limited to 100 approvals granted/received?)
FT = 0.0.1045728 (limited to 100 approvals granted/received?)

[Ashe-Oro]

also what about given approval to a smart contract? Is it impacted at all by this limitation. If I find out, I'll post here.

[hashaxis]

It would seem the allowance limit is set on an account (not on the collection token), but this is an assumption. Unclear how smart contract allowances are impacted if at all.

[hashaxis]

@Ashe-Oro has confirmed that the assumption that an allowance is set at the account level for the receiver was incorrect, and that this limit actually applies to the grantor. Thank you!