Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests for SystemDeleteTransaction #1577

Open
deyanzz opened this issue Aug 30, 2023 · 3 comments
Open

Integration tests for SystemDeleteTransaction #1577

deyanzz opened this issue Aug 30, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@deyanzz
Copy link

deyanzz commented Aug 30, 2023

Problem

Seems that SystemDeleteTransaction is missing some integration tests.

Found during PR #477.

Solution

To add new integration test suite named SystemDeleteTransactionIntegrationTest:

  • deleteFile
  • deleteContract

For reference see SystemDeleteTransactionIntegrationTests.cc from the C++ SDK.

Alternatives

No response

@deyanzz deyanzz added the enhancement New feature or request label Aug 30, 2023
@SimiHunjan SimiHunjan added this to the 2.30.0 milestone Sep 5, 2023
@thenswan thenswan self-assigned this Sep 5, 2023
@thenswan
Copy link
Contributor

thenswan commented Sep 6, 2023

@deyanzz can you please check this file?

I tried to implement a separate test for deleteFile, and it throws a pre-check with the status NOT_SUPPORTED.

@deyanzz
Copy link
Author

deyanzz commented Sep 11, 2023

As far as I can see, in SystemIntegrationTest.java in allSystemTransactionsAreNotSupported(), after creating FileCreateTransaction(), the setup for keys is missing - check line 26.

I ran several times the C++ implementation of SystemDeleteTransactionIntegrationTests.cc and it passed successfully every time on Testnet.

Maybe the setup of FileCreateTransaction is incorrect.
We should try to create the operatorKey from ED25519PrivateKey using string 302e020100300506032b65700422042091132178e72057a1d7528025956fe39b0b847f200ab59b2fdd367017f3087137 and then configure the newly created FileCreateTransaction.

@thenswan
Copy link
Contributor

Double-checked and had the same result.

@Petyo-Lukanov Petyo-Lukanov removed this from the 2.30.0 milestone Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants