Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a toJson method on receipt and record which is consistent across all SDKs #1589

Open
gregscullard opened this issue Sep 5, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@gregscullard
Copy link
Contributor

Problem

Using different SDKs with WalletConnect, it's impossible to provide a consistent JSON representation of a Receipt or Record.
.stringify and .marshal in javascript and golang output differing results.

Solution

Add a toJson method to receipt and record which convert the object to a consistent JSON format (using the JS stringify as a reference) so that all SDKs can generate identical Json.

Alternatives

Let developers write their own equivalence libraries which is likely to go wrong with changes to receipts/records.

@gregscullard gregscullard added the enhancement New feature or request label Sep 5, 2023
@thenswan thenswan self-assigned this Sep 5, 2023
@thenswan
Copy link
Contributor

thenswan commented Sep 5, 2023

Hi @gregscullard and thank you for submitting this issue. I will check it.

@gregscullard
Copy link
Contributor Author

Also for TransactionResponse

@SimiHunjan SimiHunjan added this to the 2.29.1 milestone Oct 16, 2023
@Petyo-Lukanov Petyo-Lukanov removed this from the 2.29.1 milestone Dec 20, 2023
@SimiHunjan SimiHunjan added the good first issue Issues which are ideal for a first time or new project contributor. label Aug 6, 2024
@agadzhalov agadzhalov added good first issue candidate Issues that can become a good first issue but need more description/context. and removed good first issue Issues which are ideal for a first time or new project contributor. labels Sep 4, 2024
@0xivanov 0xivanov removed the good first issue candidate Issues that can become a good first issue but need more description/context. label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants