You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#1844 introduced a new API that allowed creating Clients with an external Executor.
Multiple Clients can now share the same executor.
However, when a Client is closed it shuts down its executor no matter whether it was provided or created by the client itself.
That affects multiple clients sharing the same executor, reusing the executor for a client that had to be restarted, and lots of other scenarios where users assume control over their executor.
Steps to reproduce
Create two Clients with the same external executor
Close one Client
Continue using the second Client
Additional context
No response
Hedera network
other
Version
2.39.0
Operating system
Linux
The text was updated successfully, but these errors were encountered:
This is counterintuitive from the API point of view and I expect every developer to fall for it. I'll update my client code as suggested. However, the point that SDK should not close user provided executor is still valid.
Description
#1844 introduced a new API that allowed creating Clients with an external Executor.
Multiple Clients can now share the same executor.
However, when a Client is closed it shuts down its executor no matter whether it was provided or created by the client itself.
That affects multiple clients sharing the same executor, reusing the executor for a client that had to be restarted, and lots of other scenarios where users assume control over their executor.
Steps to reproduce
Additional context
No response
Hedera network
other
Version
2.39.0
Operating system
Linux
The text was updated successfully, but these errors were encountered: