Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do we need RequestType.java and Status.java ? #2040

Open
hendrikebbers opened this issue Oct 17, 2024 · 3 comments
Open

Why do we need RequestType.java and Status.java ? #2040

hendrikebbers opened this issue Oct 17, 2024 · 3 comments

Comments

@hendrikebbers
Copy link
Member

The two classes (identical in JS and other SDKs) look strange. The classes are wrappers around protobuf classes that created by hand but do not provide any additional information. Can we please check if the classes are really needed? I assume the classes (enums) created by protobuf are already good enough and we do not need the additonal handmade classes.

@0xivanov
Copy link
Contributor

Hi @hendrikebbers . It seems like Status could be removed, but I am not sure if there are not any users that are using the Status struct specifically for comparison.
RequestType would not be directly used, I think.

@hendrikebbers
Copy link
Member Author

Yeah, but the question is the usage of RequestType can not be refactored to us the protobuf classes directly.

@0xivanov
Copy link
Contributor

We could use the protobuf classes directly, but I cannot guarantee that someone is not using our own implementation, since they are public classes.
We could @Deprecate them and use the protobufs. After some time we could remove the 2 deprecated classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants