-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: LegacyConfigPropertiesLoader should not suppress ParseException #16133
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: Lenin Mehedy <[email protected]>
0f7b3db
to
9a59e75
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #16133 +/- ##
=============================================
+ Coverage 58.02% 58.04% +0.01%
- Complexity 19744 19749 +5
=============================================
Files 2724 2724
Lines 99673 99665 -8
Branches 10289 10287 -2
=============================================
+ Hits 57834 57846 +12
+ Misses 38233 38216 -17
+ Partials 3606 3603 -3
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NetworkUtils
has no remaining usages, and may be deleted. Otherwise LGTM
Just holding off merging it since this PR may not be sufficient to fix all the issues. I have documented my observations, current workarounds and related problems here for reference and offline discussions: https://www.notion.so/swirldslabs/Problem-DNS-lookup-issue-during-Platform-boot-1297c9ab259180fdbc2fe97019d7d7fd?pvs=4 We'll come back to it once I get confirmations from others. |
Description:
Related issue(s):
Fixes #16132
Fixes https://github.com/hashgraph/solo-operator/issues/233
Notes for reviewer:
During boot time, platform shouldn't try to resolve the FQDN addresses (internal or external) in the config.txt as other nodes may not be up by the time a node starts parsing config.txt. So this PR removes FQDN resolution at config parsing time.
Also it throws exception if
config.txt
parsing fails for other reasons at the boot time.Checklist