Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean up old smart contract ABI definitions #17118

Open
david-bakin-sl opened this issue Dec 18, 2024 · 0 comments
Open

refactor: clean up old smart contract ABI definitions #17118

david-bakin-sl opened this issue Dec 18, 2024 · 0 comments
Labels
Hedera Smart Contract Service Issues related to the Hedera Smart Contract Service.

Comments

@david-bakin-sl
Copy link
Member

  • AbiConstants is still hanging around, shouldn't be. Only remaining uses are for Ethereum event declarations. (And those are declared extremely opaquely as byte strings.). Find some other place for these event declarations (and a better notation!) and nuke this file.
    • Probably should be in the translator classes with the method declaration - they're used in the *Call and *LoggingUtils classes in the same package as the corresponding *Translator, so in other words: They're local.
  • I think it possible there's another such old file hanging around - I have this vague recollection of it but can't find it now. Look for it maybe?
  • Consider how some of our translator classes - e.g., CreateTranslator build signatures out of substrings. Some of that is done to have common definnitions of structs and reuse them. But some is just obfuscating, like a + ARRAY_BRACKETS + just for []. Reconsider this.
@david-bakin-sl david-bakin-sl added the Hedera Smart Contract Service Issues related to the Hedera Smart Contract Service. label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hedera Smart Contract Service Issues related to the Hedera Smart Contract Service.
Projects
Status: Backlog
Development

No branches or pull requests

1 participant