Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up TokenCancelAirdrop null param failure #17167

Closed
kimbor opened this issue Dec 23, 2024 · 0 comments · Fixed by #17168
Closed

clean up TokenCancelAirdrop null param failure #17167

kimbor opened this issue Dec 23, 2024 · 0 comments · Fixed by #17168
Assignees
Milestone

Comments

@kimbor
Copy link
Member

kimbor commented Dec 23, 2024

Problem

Clean up the way empty parameters are treated in TokenCancelAirdrop transactions

Solution

-Add test for TokenCancelAirdrop empty parameters
-Throw PrehandleException on empty parameters earlier in the workflow
-Change the PreHandleException that is thrown from INVALID_ACCOUNT_ID to INVALID_PENDING_AIRDROP_ID, to match the similar exception condition in TokenClaimAirdrop

Alternatives

No response

@kimbor kimbor added this to the v0.59 milestone Dec 23, 2024
@kimbor kimbor self-assigned this Dec 23, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Services Team Dec 23, 2024
@kimbor kimbor moved this from 📋 Backlog to 👷🏼‍♀️ In Progress in Services Team Dec 23, 2024
@kimbor kimbor moved this from 👷🏼‍♀️ In Progress to 👀 In Review in Services Team Jan 3, 2025
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in Services Team Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant