feat: TokenCancelAirdrop should fail fast with invalid parameters #17168
+28
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kim Rader <[email protected]>
kimbor
changed the title
kimbor
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17168 +/- ##
============================================
- Coverage 64.33% 64.33% -0.01%
+ Complexity 20941 20939 -2
============================================
Files 2555 2555
Lines 96171 96171
Branches 10055 10055
============================================
- Hits 61870 61868 -2
Misses 30663 30663
- Partials 3638 3640 +2
... and 2 files with indirect coverage changes |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Signed-off-by: Kim Rader <[email protected]>
Signed-off-by: Kim Rader <[email protected]>
…f github.com:hashgraph/hedera-services into 17167-clean-up-TokenCancelAirdrop-null-param-failure
povolev15
approved these changes
Jan 3, 2025
|
LGTM TY @kimbor |
kimbor
deleted the
17167-clean-up-TokenCancelAirdrop-null-param-failure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
TokenCancelAirdrop transactions should handle empty parameters appropriately.
Related issue(s):
Fixes #17167