-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Expose mode
to NWBZarrIO
#137
Comments
I think |
io.file.mode
Traceback (most recent call last):
File ~\AppData\Roaming\Python\Python310\site-packages\zarr\hierarchy.py:520 in __getattr__
return self.__getitem__(item)
File ~\AppData\Roaming\Python\Python310\site-packages\zarr\hierarchy.py:500 in __getitem__
raise KeyError(item)
KeyError: 'mode' Also, more to the original issue as requested by @bendichter, he wanted a universal API consistency with NWBHDF5IO in this respect |
If I remember correctly not all stores in Zarr actually support |
Looking at https://zarr.readthedocs.io/en/stable/api/storage.html#zarr.storage.DirectoryStore (which is what Zarr uses by default), does not have a |
Since the Zarr DirectoryStore does not use a mode (which is the main store used in HDFM Zarr), we decided to close this issue. If a use case for this arises please reopen the issue. |
We can expose the |
What would you like to see added to HDMF-ZARR?
Stems from catalystneuro/neuroconv#569 (comment)
The NWBHDF5IO has a
.mode
attribute publicly exposed to easily detect on an instantiated IO object what the mode was at time of instantiation (useful for determining if an in-memoryNWBFile
object was read from an existing file or created on the fly)But the NWBZarrIO does not; though the same info can be accessed via the private
._ZarrIO__mode
attributeIs your feature request related to a problem?
What solution would you like?
Expose
.mode
attribute as public instead of_ZarrIO__mode
Do you have any interest in helping implement the feature?
No.
Code of Conduct
The text was updated successfully, but these errors were encountered: