Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Test without consolidate metadata #148

Open
3 tasks done
mavaylon1 opened this issue Dec 12, 2023 · 2 comments
Open
3 tasks done

[Feature]: Test without consolidate metadata #148

mavaylon1 opened this issue Dec 12, 2023 · 2 comments
Assignees
Labels
category: enhancement improvements of code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s)

Comments

@mavaylon1
Copy link
Contributor

What would you like to see added to HDMF-ZARR?

Currently all the tests consolidate metadata into a single file, a part for a few select tests that directly opt out. We should expand the tests to repeat but now without consolidating metadata.

Is your feature request related to a problem?

No response

What solution would you like?

Above.

Do you have any interest in helping implement the feature?

Yes.

Code of Conduct

@mavaylon1 mavaylon1 self-assigned this Dec 12, 2023
@mavaylon1 mavaylon1 added category: enhancement improvements of code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s) labels Dec 12, 2023
@mavaylon1
Copy link
Contributor Author

Note: I will tackle this in January 2024

@oruebel
Copy link
Contributor

oruebel commented Dec 12, 2023

Option 1 We could do this on the level of the individual test cases. In that case we can focus on the main unit tests:

This may also require changes in the base test classes:

I think for the tests related to export and parallel write, this may not be necessary, since the main cases should be covered in the main unit tests. I.e., these may not need this:

Option 2 An alternative approach would be to have a global way to configure whether to consolidate metadata or not and then run the full test suite twice on GitHub. I.e., basically have a way to change what the default is for consolidating metadata.

Option 1 is a bit more explicit and provides more fine-grained control, but also may require more effort/code and may not easily include all tests. Option 2 may not provide as fine-grained control but could potentially be simpler to implement and would simply run all tests twice. I think if Option 2 is easy, then we could try to do that first and move to Option 1 if that doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s)
Projects
None yet
Development

No branches or pull requests

2 participants