Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Refactor to reduce code complexity #1095

Open
rly opened this issue Apr 11, 2024 · 1 comment
Open

[Feature]: Refactor to reduce code complexity #1095

rly opened this issue Apr 11, 2024 · 1 comment
Assignees
Labels
category: enhancement improvements of code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s) topic: maintenance Issues related to tech debt / code maintainability
Milestone

Comments

@rly
Copy link
Contributor

rly commented Apr 11, 2024

What would you like to see added to HDMF?

Some functions have high cyclomatic complexity and are therefore more challenging to understand and maintain. See NeurodataWithoutBorders/pynwb#191

We currently use # noqa: C901 to make the functions pass the flake8/ruff C901 check.
https://github.com/search?q=repo%3Ahdmf-dev%2Fhdmf%20C901&type=code

What solution would you like?

Refactor the functions into smaller ones or use less branching/complexity in those functions.

Do you have any interest in helping implement the feature?

No.

@rly rly added category: enhancement improvements of code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s) topic: maintenance Issues related to tech debt / code maintainability labels Apr 11, 2024
@rly rly added this to the Future milestone Apr 11, 2024
@rly
Copy link
Contributor Author

rly commented Apr 11, 2024

This is low priority, but I wanted to flag it as tech debt that would be good for us to resolve and I think it would not be too challenging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s) topic: maintenance Issues related to tech debt / code maintainability
Projects
None yet
Development

No branches or pull requests

2 participants