Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Parametrize connect Method #14

Open
mrblueblue opened this issue May 6, 2017 · 1 comment
Open

Proposal: Parametrize connect Method #14

mrblueblue opened this issue May 6, 2017 · 1 comment
Labels
enhancement tracked-in-jira Issue is being tracked in Jira, link mentioned in issue comments

Comments

@mrblueblue
Copy link
Contributor

Proposed API

const connector = new MapdCon()

const opts = {
  host: "localhost",
  port: 8080,
  user: "foo",
  password: "bar",
  dbName: "myDatabase"
}

connector
   .connect(opts)
   .then(doSomething)
   .catch(handleError)

Current API

const connector = new MapdCon()

connector
  .host('localhost')
  .port('8080')
  .dbName('myDatabase')
  .user('foo')
  .password('bar')
  .connect((err, con) => {
    if (error) handleError(error)
    doSomething(con)
  });
@jonvuri
Copy link
Contributor

jonvuri commented Apr 1, 2019

Tracking as https://jira.omnisci.com/browse/FE-8225

@jonvuri jonvuri added the tracked-in-jira Issue is being tracked in Jira, link mentioned in issue comments label Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement tracked-in-jira Issue is being tracked in Jira, link mentioned in issue comments
Projects
None yet
Development

No branches or pull requests

2 participants