Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement validation of chart config object prior to rendering #36

Open
clhenrick opened this issue Apr 16, 2018 · 0 comments
Open

Implement validation of chart config object prior to rendering #36

clhenrick opened this issue Apr 16, 2018 · 0 comments

Comments

@clhenrick
Copy link
Contributor

clhenrick commented Apr 16, 2018

As mentioned in a recent PR I'm noticing that we are starting to do some config validation within the components. I think a better way to do this would be either to introduce some static typing system like Flow or at least validate the config object each time setConfig() is called. That way we won't have to worry about whether or not a config property is of a certain type before applying it in a component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant