סוף זמן אכילה וביעור חמץ

[MaxBGreenberg]

I think a useful feature to add would be for an option to print sof zman achilas chametz and sof zman biur chametz on erev pesach. I was initially thinking of adding that to the zmanim list contingent on it the condition that the day is erev pesach is met. but then I realized that it may be better to leave that as just the zmanim that apply every day. Perhaps instead it could be added to the -c option, being printed alongside candle lighting. Do people think this could be useful? The zman for achilas chametz is the same as sof zman tefilla. the zman for sof zman biur is one halachik hour later.

[mjradwin]

Good suggestion! Given that this is only two days per year, I think it fits better with the -c option. This is what we did for fast start and end times... rather than add a new command-line flag, we just emit the start/end times for relevant minor fasts (Ta'anit Esther, Ta'anit Bechorot, Tzom Tammuz, etc) when the user wants candle-lighting times.

[MaxBGreenberg]

Ok. I will take some time to study the code base to better understand how this all works and iy"h prepare a pull request

[mjradwin]

The code probably belongs in appendHolidayAndRelated() in hebcal.go. I think the function needed would be similar to makeFastStartEnd() in candles.go