Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify top-level tag group rules in current spec #486

Open
happy5214 opened this issue Mar 28, 2023 · 1 comment
Open

Verify top-level tag group rules in current spec #486

happy5214 opened this issue Mar 28, 2023 · 1 comment

Comments

@happy5214
Copy link
Member

During our meeting yesterday, @VisLab and I discussed the rules regarding tags marked with the topLevelTagGroup schema attribute. The result was this description of each tag's rules:

  • Definition tag groups
    • ... can appear multiple times in an event line (as separate top-level groups).
    • ... must have a single inner tag group.
    • ... may be duplicated within an event file as long as they have an equivalent inner tag group.
  • Onset and Offset tag groups
  • Event-context tag groups
    • ... must only contain zero or more inner tag groups (apart from Event-context itself).
  • Duration and Delay tag groups
    • ... may have any inner tags or tag groups not otherwise prohibited (e.g. Onset and Offset).

As a clarification, a "name/value pair" in the JavaScript validator's parlance is a definition's name and (optional) placeholder value, i.e. the identifier for the definition.

@VisLab
Copy link
Member

VisLab commented Aug 15, 2023

We have modified the rules for Definition so that definitions can only appear in separate keys in JSON sidecars.

As a further restriction on Definition --- certain tags such as Condition-variable and Task may only appear once in a Definition. We need an attribute for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants