Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wireshark-dissector: Make the dissector for snapshots much more granular. #54

Open
C0D3D3V opened this issue Apr 27, 2022 · 3 comments
Open

Comments

@C0D3D3V
Copy link

C0D3D3V commented Apr 27, 2022

So that one can distinguish e.g. whether it is a CNetObj_EntityEx or CNetObj_Laser. Further it would be great if the individual data within a snapshot are named, as for example with a CNetObj_Laser (https://github.com/C0D3D3V/ddnet/blob/bc80d83ec9ad929d7f36774d2a2391379c40ffcd/datasrc/network.py#L123-L130):

  • m_X
  • m_Y
  • m_FromX
  • m_FromY
  • m_StartTick
@miguilimzero
Copy link

This would be really useful!

@ChillerDragon
Copy link
Contributor

Snap single should be fine. It will be in diffs and not the actual values. So m_X will not be the actual position but the diff to the last position. Thats still nice to see.

But regular snaps (partial snaps) will be messy. The first part might cut in the middle of a snap item. The 2nd and later parts might start their payload in the middle of a snap item. I am not sure if wireshark supports cross packet context and how smooth that could be integrated with libtw2.

@heinrich5991
Copy link
Owner

Wireshark supports reassembly of split packets: https://www.wireshark.org/docs/wsdg_html_chunked/ChDissectReassemble.html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants