Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli does handle proxy environment variables with trailing slash #1060

Open
romain-grecourt opened this issue Aug 1, 2024 · 0 comments
Open
Labels
4.x bug Something isn't working cli
Milestone

Comments

@romain-grecourt
Copy link
Contributor

If the proxy set in the environment contains non digit characters after the port, the bad characters are included.
E.g. https_proxy=com.acme:80/

The code in io.helidon.build.common.Proxies should be improved to be as robust and flexible as possible.
I.e. If an existing environment works with other tools, it should work with the Helidon CLI.


E.g.

export https_proxy=com.acme:80/
helidon --debug init --reset

  • Update io.helidon.build.common.Proxies to be unit testable (extract the parsing logic in package private static methods)
  • Take some inspiration from Helidon WebClient (discard socks proxies)
  • Find the standard or pseudo standard, add references to them in the code
@romain-grecourt romain-grecourt added bug Something isn't working cli 4.x labels Aug 1, 2024
@romain-grecourt romain-grecourt added this to the 4.0.10 milestone Aug 1, 2024
@romain-grecourt romain-grecourt modified the milestones: 4.0.10, 4.0.11, 4.0.12 Aug 19, 2024
@romain-grecourt romain-grecourt modified the milestones: 4.0.12, 4.0.13, 4.0.14 Oct 2, 2024
@romain-grecourt romain-grecourt modified the milestones: 4.0.14, 4.0.15 Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x bug Something isn't working cli
Projects
None yet
Development

No branches or pull requests

1 participant