Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow QR code scanning of transfer_hotspot_v2 transactions #1341

Open
rawrmaan opened this issue Aug 5, 2022 · 0 comments
Open

Allow QR code scanning of transfer_hotspot_v2 transactions #1341

rawrmaan opened this issue Aug 5, 2022 · 0 comments

Comments

@rawrmaan
Copy link
Contributor

rawrmaan commented Aug 5, 2022

The app should allow scanning a QR code to initiate a transfer_hotspot_v2 transaction. Importantly, the client-side check for recent hotspot activity (normally required to transfer a hotspot) should be bypassed so advanced users can make their own determination of whether a hotspot is ready to transfer.

This is the screen that pushes the transfer UI (see navigateToTransfer function): https://github.com/helium/hotspot-app/blob/main/src/features/hotspots/transfers/HotspotTransfer.tsx

And the main transfer UI is in SendView. In order to bypass the activity check, scanned transfers could follow the same code path as data-only hotspots, seen here:

if (isDataOnly(gateway)) {

@rawrmaan rawrmaan changed the title Allow QR code scanning of payment_v2 transactions Allow QR code scanning of transfer_hotspot_v2 transactions Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant