Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle LSP requests when blocking while flushing writes #12176

Open
the-mikedavis opened this issue Dec 2, 2024 · 1 comment
Open

Handle LSP requests when blocking while flushing writes #12176

the-mikedavis opened this issue Dec 2, 2024 · 1 comment
Labels
A-command Area: Commands A-language-server Area: Language server client C-enhancement Category: Improvements E-medium Call for participation: Experience needed to fix: Medium / intermediate

Comments

@the-mikedavis
Copy link
Member

#11902 (comment) points out a case where a language server appears to be awaiting a response to workspace/configuration in order to respond to textDocument/formatting. This is a problem for :write-quit since we block the main thread waiting for the textDocument/formatting response while the main thread is also responsible for replying to LSP server requests. Ideally we should be able to continue responding to LSP requests while awaiting shutdown.

@the-mikedavis the-mikedavis added C-enhancement Category: Improvements A-language-server Area: Language server client A-command Area: Commands E-medium Call for participation: Experience needed to fix: Medium / intermediate labels Dec 2, 2024
@pascalkuthe
Copy link
Member

yeah I suspected that our write flushing would eventually be an issue somewhere. We should not be shutting down the editor until writes are done. Ideally we would even show something that indicates the editor is still saving (and allow cancelling the shutdown ala #6436)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-command Area: Commands A-language-server Area: Language server client C-enhancement Category: Improvements E-medium Call for participation: Experience needed to fix: Medium / intermediate
Projects
None yet
Development

No branches or pull requests

2 participants