replace_selections_with_clipboard doesn't remove cr on windows

[sibouras]

Summary

when copying multiline text on windows and then replacing the selection with space+R the carriage return cr doesn't get removed which causes bugs in biome formatting, pasting with space+p works fine though

Reproduction Steps

sample code to copy

const people = [
	{ name: "one", year: 2000 },
	{ name: "two", year: 2001 },
	{ name: "three", year: 2002 },
	{ name: "four", year: 2003 },
];

hx-biome-bug.mp4

I tried this:

1. open helix, paste the sample text and save
2. biome format , no cr is showing(expected)
3. replace the selection with space+R
4. biome format shows cr
5. run fmt multiple times and biome gets confused

this is my config

[[language]]
name = "javascript"
language-servers = [
  { name = 'biome' },
  { name = 'typescript-language-server', except-features = ['format'] },
]

[language-server.biome]
command = "biome"
args = ["lsp-proxy"]
required-root-patterns = ["biome.json", "biome.jsonc"]

Helix log

~/.cache/helix/helix.log

please provide a copy of `~/.cache/helix/helix.log` here if possible, you may need to redact some of the lines

Platform

windows

Terminal Emulator

windows-terminal

Installation Method

source

Helix Version

helix 24.7 (91a5d40)

[RoloEdits]

Looks like paste has a regex to remove the endings

helix/helix-term/src/commands.rs

Lines 4433 to 4439 in 9e77c44

	// Only compiled once.
	static REGEX: Lazy<Regex> = Lazy::new(|| Regex::new(r"\r\n|\r|\n").unwrap());
	let mut values = values
	.iter()
	.map(|value| REGEX.replace_all(value, doc.line_ending.as_str()))
	.map(|value| Tendril::from(value.as_ref().repeat(count)))
	.chain(repeat);

Replace doesnt

helix/helix-term/src/commands.rs

Lines 4528 to 4557 in 9e77c44

	fn replace_with_yanked_impl(editor: &mut Editor, register: char, count: usize) {
	let Some(values) = editor
	.registers
	.read(register, editor)
	.filter(|values| values.len() > 0)
	else {
	return;
	};
	let values: Vec<_> = values.map(|value| value.to_string()).collect();
	let scrolloff = editor.config().scrolloff;
	let (view, doc) = current!(editor);
	let repeat = std::iter::repeat(
	values
	.last()
	.map(|value| Tendril::from(&value.repeat(count)))
	.unwrap(),
	);
	let mut values = values
	.iter()
	.map(|value| Tendril::from(&value.repeat(count)))
	.chain(repeat);
	let selection = doc.selection(view.id);
	let transaction = Transaction::change_by_selection(doc.text(), selection, |range| {
	if !range.is_empty() {
	(range.from(), range.to(), Some(values.next().unwrap()))
	} else {
	(range.from(), range.to(), None)
	}
	});

Though I feel biome behaving like this should also be considered a bug. Might be worth to open an issue there as well to see if this is the failing behavior expected.

[sibouras]

thanks for looking into this, and ye i was wondering where i should open this issue. but for consistency sake shouldn't helix replace remove the endings like in paste?

anyways i opened the issue in biome as well biomejs/biome#4789