Skip to content
This repository has been archived by the owner on Jan 28, 2024. It is now read-only.

Remove need for app.json to define test environment #34

Open
douglascayers opened this issue Jun 18, 2018 · 1 comment
Open

Remove need for app.json to define test environment #34

douglascayers opened this issue Jun 18, 2018 · 1 comment

Comments

@douglascayers
Copy link
Contributor

douglascayers commented Jun 18, 2018

Currently, developers add the app.json file to their project to hook into Heroku Flow. However, the test scripts property reveals scripts and knowledge specific to the buildpack itself:

./vendor/sfdx/release.sh ci-$HEROKU_TEST_RUN_COMMIT_VERSION

This feature request is for the buildpack to provide a default test-compile and test scripts (as mentioned here) that (a) can be called by both Heroku CI and #33 and (b) allow the removal of test scripts from app.json unless a developer needs to tweak the behavior.

image

@wadewegner
Copy link
Contributor

Similar to #35, it'd be nice to hear from @ike-delorenzo and @devarispbrown if there's a better way to approach.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants