Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wget doesn't check certificate #19

Open
savchenko opened this issue Nov 1, 2018 · 4 comments
Open

Wget doesn't check certificate #19

savchenko opened this issue Nov 1, 2018 · 4 comments

Comments

@savchenko
Copy link

In hetrixtools_agent.sh:

# Post data
wget -t 1 -T 30 -qO- --post-file="$ScriptPath/hetrixtools_agent.log" --no-check-certificate https://sm.hetrixtools.com/ &> /dev/null

What's the point of --no-check-certificate?..

sslyze --certinfo sm.hetrixtools.com:443 | grep -E 'Issuer|Status'
       Issuer:                            COMODO ECC Domain Validation Secure Server CA 2
       OCSP Response Status:              successful
       Cert Status:                       good
@hetrixtools
Copy link
Owner

Some systems that haven't installed or updated their CA certificates may run into SSL errors even when accessing valid SSL hosts. The --no-check-certificate is there to ensure maximum compatibility for our agent. Feel free to remove it in your agent, if you wish to do so; it should have no negative impact on most systems.

@savchenko
Copy link
Author

savchenko commented Nov 3, 2018

I get your motivation, but to the best of my understanding this is welcoming MITM during agent deployment and data being posted to Hetrix.

@twiddern
Copy link

twiddern commented Nov 2, 2019

You may could add an switch like --ignore-cert-issues to the install code window, that user can use during deployment.
By default the certificate should be checked against local root-ca

@foxycode
Copy link
Contributor

foxycode commented Mar 7, 2020

Solution could be embed certificate like here: https://github.com/calmh/smartos-platform-upgrade/blob/master/platform-upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants