Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.0.0.0 is not addressable, use 127.0.0.0 by default #1657

Closed
leesei opened this issue Dec 15, 2015 · 4 comments
Closed

0.0.0.0 is not addressable, use 127.0.0.0 by default #1657

leesei opened this issue Dec 15, 2015 · 4 comments
Labels
discussion enhancement New feature or request

Comments

@leesei
Copy link
Member

leesei commented Dec 15, 2015

The change is in hexojs/hexo-server, but this breaks the feature of allowing other machines to visit the site via hexo-server (which I think is good).
We have to change all the documents in hexojs/site to reflect this change.
Also add workaround (specifying the ip) to maintain current behavior.

See hexojs/hexo-server#14 and jekyll/jekyll#3048 for the discussion.

@leesei leesei added the enhancement New feature or request label Dec 15, 2015
@Xuanwo
Copy link
Contributor

Xuanwo commented Dec 15, 2015

I find it better to merge hexojs/hexo-server#14 into master.

And we should update docs of hexo-server to educate people not to use hexo-server for production.

@leesei
Copy link
Member Author

leesei commented Dec 15, 2015

I totally agree that hexojs/hexo-server#14 will be in, but not without or before the corresponding docs update.

@Xuanwo
Copy link
Contributor

Xuanwo commented Dec 15, 2015

Firstly, let's have a discussion in the society.
If dicided to do so, we can begin to do the work of docs, and I can do to zh-cn part.

BTW, ref: hexojs/site#133
If do it this, let's begin it from english version.

@leesei
Copy link
Member Author

leesei commented Feb 20, 2016

hexojs/hexo-server@4103a75 changed the display of hexo-server
We will stick with 0.0.0.0 as default.

@leesei leesei closed this as completed Feb 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants