Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indication of future time #10

Open
soren121 opened this issue Nov 13, 2014 · 2 comments · May be fixed by #11
Open

Indication of future time #10

soren121 opened this issue Nov 13, 2014 · 2 comments · May be fixed by #11

Comments

@soren121
Copy link

I know this script handles times in the future, but the formatting doesn't indicate whether a date is in the past or the future, which leaves things rather ambiguous. Would it be possible to prepend future times with "in" (e.g. "in 5m") or a negative symbol?
@hijonathan
Copy link
Owner

That sounds reasonable. Would you be interested in creating a pull request? I think the best thing to do would be to follow the same syntax as moment.fromNow() and pass a true argument to remove the prefix/suffix, as gross as that seems.

@soren121
Copy link
Author

Sure, I can do that.

@soren121 soren121 linked a pull request Nov 25, 2014 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add indication of future time soren121/moment.twitter
2 participants
@soren121 @hijonathan