Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback #1

Open
addyosmani opened this issue Apr 23, 2013 · 1 comment
Open

Feedback #1

addyosmani opened this issue Apr 23, 2013 · 1 comment

Comments

@addyosmani
Copy link

Readme:

  • "Add to package.json my fork of that project." - I believe your changes were merged and you now link to blai's work. Probably good to revise this in the readme.
  • "Add grunt by doing something along those lines" - I think this should be taken care of for the user if possible

Express scaffolding

We discussed this over on the other issue.

Over on the old ExpressStack branch we had this Express generator, which might be useful as a reference point: https://github.com/yeoman/yeoman/tree/express-stack/generators/express. A more up to date version might be used to run yo express post, yo express:crud etc.

Would you like to explore putting together something similar for this example?

@hmalphettes
Copy link
Owner

@addyosmani thanks for the feedback.

Readme:

I removed the mention of the fork of @blai's grunt-express as indeed the change was merged in.
Regarding your suggestion to automate the setup of grunt-express: yes that should be something done by the tool.

Dust is accumulating on this repo: it needs an update!
Let's leave this old example behind and do something fresh and up to date?

Express scaffolding

When I worked on this example, I had a good long look at the ExpressStack generator.
I am seduced by the ability to scaffold the stack one bit at a time with yo.
At this point I can't commit to have enough time to do something very thorough.

How about this:
I'll redo the example with the latest yeoman; bring-in karma and up-to-date generators.
I'll leave the current master into a separate branch; rebase master on a virgin repo and try this again.

Then we can look at how to improve it and eventually improve the rest of the ecosystem used for this.

What do you think?

Thanks for your interest!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants