Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Dask as a hard dependency of Datashader #1350

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Remove Dask as a hard dependency of Datashader #1350

wants to merge 14 commits into from

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Jul 3, 2024 •
edited
Loading

Resolves #1349

jbednar
jbednar reviewed Jul 3, 2024
View reviewed changes
Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, when we discussed this on Discord yesterday I thought this would go onto the backlog and never get done, but here it is already being addressed! What a nice feeling! Looks good so far; just what I'd expect to see.

@jbednar jbednar mentioned this pull request Jul 3, 2024
Open
@codecov Codecov
Copy link

codecov bot commented Jul 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 63.28125% with 47 lines in your changes missing coverage. Please review.

Project coverage is 88.39%. Comparing base (083b93b) to head (dbed0b1).
Report is 1 commits behind head on main.

Files Patch % Lines
datashader/bundling.py 36.36% 7 Missing ⚠️
datashader/tests/test_raster.py 68.42% 6 Missing ⚠️
datashader/tiles.py 33.33% 6 Missing ⚠️
datashader/tests/test_transfer_functions.py 55.55% 4 Missing ⚠️
datashader/tests/test_xarray.py 60.00% 4 Missing ⚠️
datashader/core.py 75.00% 3 Missing ⚠️
datashader/resampling.py 66.66% 3 Missing ⚠️
datashader/tests/test_quadmesh.py 76.92% 3 Missing ⚠️
datashader/tests/test_dask.py 66.66% 2 Missing ⚠️
datashader/tests/test_geopandas.py 50.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1350      +/-   ##
==========================================
- Coverage   88.57%   88.39%   -0.18%     
==========================================
  Files          93       93              
  Lines       18642    18722      +80     
==========================================
+ Hits        16512    16550      +38     
- Misses       2130     2172      +42

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro
Copy link
Member Author

hoxbro commented Jul 4, 2024

I can see we need to update HoloViews at least in one place:

https://github.com/holoviz/holoviews/blob/eb79ab52414f53b5990f2b624edd4ba582a3fa6e/holoviews/operation/datashader.py#L5

@hoxbro hoxbro added this to the v0.17.0 milestone Jul 4, 2024
@hoxbro hoxbro marked this pull request as ready for review July 4, 2024 09:50
@hoxbro hoxbro mentioned this pull request Jul 4, 2024
Merged
@hoxbro hoxbro requested a review from philippjfr August 18, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbednar jbednar jbednar left review comments

@philippjfr philippjfr Awaiting requested review from philippjfr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.

Remove Dask as a hard dependency of Datashader
2 participants
@hoxbro @jbednar