Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include host in Peblar EV-Charger discovery setup description #133954

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Include host in Peblar EV-Charger discovery setup description #133954

wants to merge 1 commit into from
+4 −1

Conversation

DCSBL
Copy link
Contributor

@DCSBL DCSBL commented Dec 24, 2024

Proposed change

Include host in Peblar EV-Charger discovery setup description, fixes #133942, where it is hard to see which charger you are configuring.

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@DCSBL DCSBL requested a review from frenck as a code owner December 24, 2024 12:07
@home-assistant
Copy link

Hey there @frenck, mind taking a look at this pull request as it has been labeled with an integration (peblar) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of peblar can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign peblar Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

frenck
frenck reviewed Dec 24, 2024
View reviewed changes
homeassistant/components/peblar/strings.json
@@ -51,7 +51,7 @@
"data_description": {
"password": "[%key:component::peblar::config::step::user::data_description::password%]"
},
"description": "Set up your Peblar EV charger to integrate with Home Assistant.\n\nTo do so, you will need the password you use to log into the Peblar EV charger' web interface.\n\nHome Assistant will automatically configure your Peblar EV charger for use with Home Assistant."
"description": "Set up your Peblar EV charger at {host} to integrate with Home Assistant.\n\nTo do so, you will need the password you use to log into the Peblar EV charger' web interface.\n\nHome Assistant will automatically configure your Peblar EV charger for use with Home Assistant."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is well, I just wonder if we should store the whole ZeroconfServiceInfo (instead of just the host) and use something like

hostname (IP address) instead?

Copy link
Contributor Author

@DCSBL DCSBL Dec 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case we maybe could use the more friendly hostname, (PBLR-<something>) which is more recognisable?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is what I meant:

PBLR-0000645 (10.10.11.56)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or even write it out

Set up your Peblar EV charger PBLR-0000645, on IP address 10.10.11.56, to integrate with Home Assistant

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be nice!

Will do that, but it will take a day or two longer due some reasons 🎄.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can pick up if you are ok with that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sure!

@frenck frenck added this to the 2025.1.0 milestone Dec 24, 2024
@DCSBL DCSBL marked this pull request as draft December 24, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenck frenck frenck left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@frenck frenck

Labels
cla-signed code-quality integration: peblar Quality Scale: platinum small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2025.1.0
Development

Successfully merging this pull request may close these issues.

Impossible to know which Peblar EV-Charger is being configured when having multiple
2 participants
@DCSBL @frenck