Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refinery - add option to generate ServiceMonitor #290

Open
mrobinson513 opened this issue Sep 14, 2023 · 0 comments
Open

Refinery - add option to generate ServiceMonitor #290

mrobinson513 opened this issue Sep 14, 2023 · 0 comments
Labels
type: enhancement New feature or request

Comments

@mrobinson513
Copy link

Is your feature request related to a problem? Please describe.

This request is similar to #14, but for Refinery.

Currently when Refinery is released with PrometheusMetrics.enabled: true (default), the deployment is automatically annotated such that a running Prometheus instance will scrape the relevant endpoint. Generally this is fine, but does not support more advanced configuration options, such as relabeling or dropping certain metrics.

Describe the solution you'd like

One of two possible outcomes:

  1. Provide the option to create a ServiceMonitor similar to the feature request made in opentelemetry-collector: add option to generate ServiceMonitor #14.
  2. Provide the option to provide an existing ServiceMonitor, and by doing so skipping the prometheus annotations in the deployment.

Describe alternatives you've considered

None; currently using the existing pod annotations.

Additional context

Dropping certain metrics can become necessary if an org is attempting to trim some observability costs with a vendor, like the reason Refinery exists 😃

@mrobinson513 mrobinson513 added the type: enhancement New feature or request label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant