Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json schemas for values.yml #75

Open
ismith opened this issue Nov 5, 2021 · 0 comments
Open

json schemas for values.yml #75

ismith opened this issue Nov 5, 2021 · 0 comments
Labels
type: enhancement New feature or request

Comments

@ismith
Copy link
Contributor

ismith commented Nov 5, 2021

Is your feature request related to a problem? Please describe.
Bringing this here for discussion at @bdarfler's request.

I made a change today to the values we specify for our lacework deploy in a particular environment, and on my first attempt, got it wrong.

However, this got caught in our dry run in CI, because lacework's chart contains a values.schema.json, and so the pre-merge dry-run was able to tell me:

Error: UPGRADE FAILED: values don't meet the specifications of the schema(s) in the following chart(s):
lacework-agent:
- image.imagePullSecrets.0: Invalid type. Expected: object, given: string

Which is pretty great! I think we may want to do similar work for our helm charts such that helm upgrade --install --dry-run can tell a developer "hi you've written a values.yml for your config that isn't valid". Like having TypeScript annotations for a library.

@ismith ismith added the type: enhancement New feature or request label Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant