Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't set http.status (or other fields with a .) #53

Closed
kentquirk opened this issue May 6, 2024 · 0 comments · Fixed by #55
Closed

Can't set http.status (or other fields with a .) #53

kentquirk opened this issue May 6, 2024 · 0 comments · Fixed by #55
Labels
type: bug Something isn't working

Comments

@kentquirk
Copy link
Collaborator

Customer report
Steps to reproduce

❯ ./loadgen --sender=print --depth=10 --nspans=5 http.status=/st10,5
unable to create fields as specified: unparseable user field http.status=/st10,5

I can't set http.status, it seems.

Additional context
The problem is the argument parser not accepting . in a name field.
@kentquirk kentquirk added the type: bug Something isn't working label May 6, 2024
@skpy skpy mentioned this issue May 22, 2024
Merged
kentquirk pushed a commit that referenced this issue May 22, 2024
@skpy
fix: support . in field names (#55)
a79e715 
## Which problem is this PR solving?

- #53 

## Short description of the changes

- This adds `.` to the list of characters to match in the `constpat`
regex. This should allow field names to contain dots, allowing us to
make more realistic trace data: `http.status_code=/st10,0.1`, and
`http.route=/u` and the like.

Fixes #53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: support . in field names skpy/loadgen
1 participant
@kentquirk