Releases · honeycombio/refinery

v0.9.0 2020-09-01

Features:

Adds dry run mode. When getting started with samproxy or when updating sampling rules, it may be helpful to verify that the rules are working as expected before you start dropping traffic. By enabling dry run mode, all spans in each trace will be marked with the sampling decision in a field called samproxy_kept. All traces will be sent to Honeycomb regardless of the sampling decision. You can then run queries in Honeycomb on this field to check your results and verify that the rules are working as intended. Enable dry run mode by adding DryRun = true in your configuration, as noted in rules.toml.

Improvements:

Libhoney-go supports msgpack. Now samproxy does as well.
Adds the stack trace to the logger in the case of panics.
Allow the debug service address to be specified in config. Specify the address in config.toml using DebugServiceAddr.

Fixes:

The peer list can temporarily become empty when using Redis discovery and the Redis state is lost (e.g. restarting an in-memory instance). This caused a panic when attempting to choose a shard, and resulted in dropping spans. Now, we return an error when there are no peers, which means that it will surface the error to the logs and re-attempt later.

The sampling rules configuration was split into a separate file from the main configuration file. You can specify the path to the main config file through the command line flag -c, as before. The rules file path can be specified with -r. The paths default to /etc/samproxy/samproxy.toml and /etc/samproxy/rules.toml.
The -p command line flag for configuring redis is deprecated. Instead, there is a Peer Management section in the main config file where Type="redis" should be specified. This field defaults to Type="file". All other redis configuration remains unchanged.
The configuration fields of SendDelay and TraceTimeout have been switched to type of time.duration.

Features:

Improvements:

Process accumulated traces on a single time interval instead of per trace, which uses a lot less CPU to do the same job in the same time
Split config into config.toml for general configuration and rules.toml for sampling, and add reasonable defaults to ease the startup experience
Simplify startup flow when using redis
Use Viper to manage configuration
Use go modules instead of vendored dependencies
Add samproxy/version to user agent addition
Add -debug flag which when used, will run a debug service on port 6060 (The debug service allows you to use pprof to visualize and analyze profiling data.)
Switch to time.duration for several config values, including SendDelay and TraceTimeout

Fixes: