Skip to content
This repository has been archived by the owner on Jan 29, 2024. It is now read-only.

Gradient sanitizing (clipping) helps a lot :) #1

Open
akanimax opened this issue Nov 3, 2019 · 1 comment
Open

Gradient sanitizing (clipping) helps a lot :) #1

akanimax opened this issue Nov 3, 2019 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@akanimax
Copy link

akanimax commented Nov 3, 2019

@huangzh13,

At the outset, this is a great implementation of StyleGAN in PyTorch. I really like the way the modules are structured.
This is more of a suggestion from my side:
Seems like you are not sanitizing your gradients in the code. Please check this from the official StyleGAN implementation.
I am currently working on incorporating this in my pro_gan_pytorch and BMSG-GAN.

From experience, this makes the results much better. Specifically, your generated results seem to have a few checkerboard artifacts when zoomed. These tend to disappear with gradient sanitization.

I think the easiest way to implement this is with a backward hook in pytorch.

Hope this helps!
Again great job 👏

Cheers 🍻!
@akanimax

@akanimax akanimax changed the title Gradient sanitizing (clipping) helps a lot 😄 Gradient sanitizing (clipping) helps a lot :) Nov 3, 2019
@huangzh13
Copy link
Owner

@akanimax
Thanks for your encouragement!
I used to refer to the official tensorflow implementation, but did not notice the key points you mentioned (after all, it is hidden in tflib). Thank you!
I will continue to work hard to add more features to my implementation.

Best,
@huangzh13

@huangzh13 huangzh13 added enhancement New feature or request good first issue Good for newcomers labels Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants