Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] evaluation on view page #253

Open
holkexyz opened this issue Sep 25, 2024 · 2 comments · Fixed by #261
Open

[UI] evaluation on view page #253

holkexyz opened this issue Sep 25, 2024 · 2 comments · Fixed by #261
Labels
to be picked up Open issues that are easy to be picked up

Comments

@holkexyz
Copy link
Member

On the view page of a hypercert the checkmarks for the evaluations are too far away from the text.

Suggested solution:

  • Have up to two evaluations side by side (responsive design)
  • Have a border around each evaluation like the boxes of contributors and owners
  • Have a max width of each evaluation like the boxes of contributors and owners

Basically the suggestion is to have it the same as the contributor and owner boxes

Image

@holkexyz holkexyz converted this from a draft issue Sep 25, 2024
@bitbeckers bitbeckers linked a pull request Sep 30, 2024 that will close this issue
@bitbeckers
Copy link
Contributor

Made the cards a bit more compact and they fit nicely on a mobile view

@0xRowdy 0xRowdy removed their assignment Sep 30, 2024
@holkexyz
Copy link
Member Author

holkexyz commented Oct 2, 2024

Looks great, thanks @bitbeckers

Small improvements:

  1. The box is higher than needed, can we make that flexible? with multiple evaluations the boxes should be still the same though
  2. The button "show full comments" is shown even when the full comment is visible. Can the button be dynamic, ie only be shown if the comments is cut?

image

@holkexyz holkexyz added the to be picked up Open issues that are easy to be picked up label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to be picked up Open issues that are easy to be picked up
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

3 participants