Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight inaccuracy in operation queues length metric #4692

Open
Tracked by #3321
daniel-savu opened this issue Oct 16, 2024 · 0 comments
Open
Tracked by #3321

Slight inaccuracy in operation queues length metric #4692

daniel-savu opened this issue Oct 16, 2024 · 0 comments
Labels
bug Something isn't working relayer

Comments

@daniel-savu
Copy link
Contributor

Problem

As a result of #4689, a bug was introduced where we missed some spots where decrementing the queue metric should have happened. Most of those were caught in #4691, but the queues for some chains are still overestimating the length by ~1.4%.

Should understand why that is still happening. If all op_queue.pop(...)s have an associated op_queue.push(op) or an op.decrement_metric_if_exists() call the metric would be accurate, so it must be that some popped operations go out of scope without either.

The way I measured the inaccuracy was by checking the grafana metric against the number of items returned by the list_operations relayer endpoint.

@daniel-savu daniel-savu added bug Something isn't working relayer labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working relayer
Projects
Status: No status
Development

No branches or pull requests

1 participant