Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create / demonstrate in tests method for recovering address from signTypedData #2019

Open
thegeronimo opened this issue Mar 19, 2024 · 0 comments
Labels
needs-review issue/PR needs review from maintainer

Comments

@thegeronimo
Copy link

Issue_title

There doesn't seem to be a clear way to verify the output of signTypedData.

Issue_description

Recovering the public address from a signature and message from signTypedData is not clear. While there is a test for signedTypedData there is not a test for recovering the public key. Such a test would serve as good documentation for how it can be done using the library and will also serve to make the codebase more robust.

Issue_context

signedTypedData definition: https://github.com/web3j/web3j/blob/master/crypto/src/main/java/org/web3j/crypto/Sign.java#L85

testSignedTypedData: https://github.com/web3j/web3j/blob/master/crypto/src/test/java/org/web3j/crypto/SignTest.java#L87

@thegeronimo thegeronimo added the needs-review issue/PR needs review from maintainer label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review issue/PR needs review from maintainer
Projects
None yet
Development

No branches or pull requests

1 participant