Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Licenses need fixed. #2088

Open
ryjones opened this issue Aug 7, 2024 · 3 comments
Open

Licenses need fixed. #2088

ryjones opened this issue Aug 7, 2024 · 3 comments
Assignees
Labels
needs-review issue/PR needs review from maintainer

Comments

@ryjones
Copy link

ryjones commented Aug 7, 2024

These files are under the GPL-3.0 or LGPL-3.0 license, a strong copyleft license, which is incompatible with your project license. These files must be removed from your repo.

Here is the report.

Finding #1
Priority: High
These files are under the GPL-3.0 or LGPL-3.0 license, a strong copyleft license, which is incompatible with your project license. These files must be removed from your repo.

  • web3j-2024-07-24.zip/web3j-cli/libs/smartcheck.jar/META-INF/maven/ru.smartdec/smartcheck/pom.xml
  • web3j-2024-07-24.zip/web3j-maven-plugin/src/test/resources/issue-09.sol
  • web3j-2024-07-24.zip/web3j-maven-plugin/src/test/resources/issue-106/sample.sol
  • web3j-2024-07-24.zip/web3j/codegen/src/test/resources/solidity/arraysinstruct/ArraysInStruct.sol
  • web3j-2024-07-24.zip/web3j-openapi/codegen/src/test/resources/contracts/radish34/BN256G2.sol
@ryjones ryjones added the needs-review issue/PR needs review from maintainer label Aug 7, 2024
@NickSneo
Copy link
Contributor

@ryjones I will remove them in upcoming release.

@gtebrean gtebrean mentioned this issue Aug 14, 2024
3 tasks
@gtebrean
Copy link
Contributor

gtebrean commented Aug 18, 2024

fixed most of the files, only these left to be checked:
web3j-2024-07-24.zip/web3j-openapi/codegen/src/test/resources/contracts/radish34/BN256G2.sol
web3j-2024-07-24.zip/web3j-cli/libs/smartcheck.jar/META-INF/maven/ru.smartdec/smartcheck/pom.xml

@NickSneo
Copy link
Contributor

NickSneo commented Oct 7, 2024

fixed for web3j-2024-07-24.zip/web3j-openapi/codegen/src/test/resources/contracts/radish34/BN256G2.sol
PR - hyperledger-web3j/web3j-openapi#113

What is the issue with - web3j-2024-07-24.zip/web3j-cli/libs/smartcheck.jar/META-INF/maven/ru.smartdec/smartcheck/pom.xml
We dont commit this file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review issue/PR needs review from maintainer
Projects
None yet
Development

No branches or pull requests

4 participants