Add option to set JSON indentation depth

[Cielquan]

🚀 Feature Proposal

Add an option to specify the indentation of the JSON file when converting from po to JSON files.

Motivation

I use a simple custom script which uses i18next-conv to convert my po files to JSON files. I also use prettier for auto-formatting via pre-commit. prettier by default indents JSON files by 2 spaces, but i18next-conv creates them with 4 spaces. Thus the pre-commit hook fails once because of this.
If there was the option to set the indentation to 2 this issue would be resolved.

Example

The indentation would be able to be set via CLI and the API in custom scripts.

[perrin4869]

I'll merge a PR implementing this :)
Maybe add the ability to specify a json formatter?

[Cielquan]

I'll merge a PR implementing this :)

Thanks :)

Maybe add the ability to specify a json formatter?

That sound also like a good idea. Maybe both? You can either set a number or a string containing a formatter wich then gets mapped to a number?

[perrin4869]

I think one of the two is better? I can go with either!
Can't think of a name for a combined option, it would be something like jsonFormatter or jsonTabWidth I think?

[Cielquan]

Well the naming sure is a problem indeed.

I guess then when both options are being implemented two separate options should be created, but then there would be the issue of which takes precedence and so on. So yeah, I guess one would be better?

But when only one is implemented I would propose to take the more general one with jsonTabWidth as it is more flexible and the user can do everything the jsonFormatter option would allow and more.

What do you think?

[perrin4869]

Well, jsonFormatter is the more general option.
You could specify something like --jsonFormatter ./jsonFormatter.js which could look something like:

import beautify from "json-beautify";

export default (obj) => beatufy(obj, null, 2, 100));

This is using something like https://www.npmjs.com/package/json-beautify
In this case you can also set the maximum line width.

[Cielquan]

Ah ok, I had a different approach in mind. I thought that the formatter option would just be a string, which then would get mapped into a number. But your approach is much better. Yes with this I would agree with you, that this would be the more general option. I like it.

[paulschreiber]

I hit the same problem with prettier vs the converter. Would also like to see this.