Add support for i18next v24 #1093
Conversation
v24 no longer supports compatibilityJSON=v3 so skip the tests for i when running with i18next v24. Fixes i18next#1090
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
| @@ -36,7 +36,7 @@ | |||
| "esbuild": "^0.23.0", | |||
| "fs-extra": "^11.2.0", | |||
| "gulp-sort": "^2.0.0", | |||
| "i18next": "^23.5.1", | |||
| "i18next": "^23.5.1 || ^24.0.0", | |||
There was a problem hiding this comment.
Would it make sense to stop supporting v23 entirely instead?
If so, since that would be a breaking change, would it make sense to also move i18next to a peerDependency? It would help upstream projects with their dependency management.
There was a problem hiding this comment.
Would it make sense to stop supporting v23 entirely instead?
Your call. I seemed easy enough to support both, and it would make my life easier as I have various packages using i18next that depend on this, so I could update things gradually. But I'd be happy to change things if wanted.
If so, since that would be a breaking change, would it make sense to also move
i18nextto a peerDependency? It would help upstream projects with their dependency management.
I don't quite understand how peerDependency could help as I've never worked with that. Note that i18next-parser is importing/using i18next directly (
i18next-parser/src/transform.js
Line 69 in 69a25da
v24 no longer supports compatibilityJSON=v3 so skip the tests for it when running with i18next v24.
Fixes #1090
Why am I submitting this PR
See title
Does it fix an existing ticket?
Yes #1090
Checklist
yarn test(see details here)