Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading OSD tab is so slow #2209

Open
error414 opened this issue Oct 15, 2024 · 1 comment
Open

Loading OSD tab is so slow #2209

error414 opened this issue Oct 15, 2024 · 1 comment

Comments

@error414
Copy link
Contributor

Loading OSD tab is incredibly slow. It's caused by calling updateOSDCustomElementsDisplay.

Loading custom OSD elements fire "change" event for each filled input in custom element block. So if four custom elements are used. then it means 4 * 4 = 16, 16 calling of updateOSDCustomElementsDisplay, in updateOSDCustomElementsDisplay is called OSD.GUI.updatePreviews(); what is incredibly slow if it's called in the loop.

So for future be careful about calling OSD.GUI.updatePreviews();.

slow_osd

@MrD-RC
Copy link
Collaborator

MrD-RC commented Oct 15, 2024

Looks like it would be good if change events could be blocked until the page has finished loading. Then call the update previews once the page has finished loading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants