Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integer min/max #11

Open
IgorRodchenkov opened this issue May 10, 2017 · 1 comment
Open

Integer min/max #11

IgorRodchenkov opened this issue May 10, 2017 · 1 comment

Comments

@IgorRodchenkov
Copy link

There might be a hidden bug because
Integer.MIN_VALUE != -Integer.MAX_VALUE
but e.g., in LGraph these are used inconsistently...

I suspect - instead of -Integer.MAX_VALUE must always use Integer.MIN_VALUE

@razrabot
Copy link

@IgorRodchenkov I think you are absolutely right. Integer.MIN_VALUE != -Integer.MAX_VALUE will always return true, because MAX_VALUE + MIN_VALUE = -1 And the inconsistency is all over the place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants