You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Perhaps this is what is intended, but this annoyingly breaking for me. I was making plots with altair as alt.Chart(table.to_pandas()) using tables with a date column. Before, the pandas DF had type datetime64. This is serializable to JSON for altair/vega, and worked. Now, the datetime.date objects are not serializable to JSON, and I get an error. I think the old behavior was better, since .to_pandas() implies to me that we are going to pandas-land, and so we should use as canonical-to-pandas-as-possible dtypes.
It seems like you really thought about the semantics of this already per some comments in that issue and linked PR, but curious if there would be a problem with these semantics:
DateScalar.to_pandas() -> pd.Timestamp
DateColumn.to_pandas() -> pd.Series[datetime64]
DateScalar.execute() -> pd.Timestamp (because by definition this uses pandas)
What happened?
This is what currently happens on main, per a change I instigated in #7299:
Perhaps this is what is intended, but this annoyingly breaking for me. I was making plots with altair as
alt.Chart(table.to_pandas())
using tables with adate
column. Before, the pandas DF had type datetime64. This is serializable to JSON for altair/vega, and worked. Now, thedatetime.date
objects are not serializable to JSON, and I get an error. I think the old behavior was better, since .to_pandas() implies to me that we are going to pandas-land, and so we should use as canonical-to-pandas-as-possible dtypes.It seems like you really thought about the semantics of this already per some comments in that issue and linked PR, but curious if there would be a problem with these semantics:
What version of ibis are you using?
main
What backend(s) are you using, if any?
NA
Relevant log output
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: