Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another Documentation issue #21

Open
alanef opened this issue Aug 22, 2017 · 2 comments
Open

Another Documentation issue #21

alanef opened this issue Aug 22, 2017 · 2 comments

Comments

@alanef
Copy link

alanef commented Aug 22, 2017

Documentation says to install the php file and a file in settings.

However the main php file registered some scripts in assets, by not having the folders give browser console issues

wp_register_script('jquery-ui-timepicker', $this->options_url.'assets/vendor/jquery-timepicker/jquery.ui.timepicker.js', array('jquery', 'jquery-ui-core'), false, true); wp_register_script('wpsf', $this->options_url.'assets/js/main.js', array('jquery'), false, true);

@jamesckemp
Copy link
Contributor

Hey, sorry what do you mean by "by not having the folders give browser console issues"?

@alanef
Copy link
Author

alanef commented Feb 8, 2018

Instructions say

  • Drop wp-settings-framework.php in the root of your plugin folder.
  • Create a "settings" folder in your plugin root.
  • Create a settings file in your new "settings" folder (e.g. settings-general.php)

But omit to say "and copy assets/vendor" as without these the files are obviously not found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants