Inheriting from INSFVMomentumAdvection #16949
-
Hello: In my application, I need to have density(P,T) in a weakly compressible formulation. So, no worries about shock capturing etc. I would like to base my app on INSFV (or PINSFV). But it seems that I have a problem with inheritance. Namely, in INSFVMomentumAdvection (and related kernels & BCs), the density is given by: /// Density and is a required parameter: and initialized by: I can't think of a way to inherit from this and transform _rho to an ADMaterialProperty. Is there some way to accomplish this? Thanks, |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 5 replies
-
Hi @joe61vette. It was after charged discussion that we made the design choice to make |
Beta Was this translation helpful? Give feedback.
Hi @joe61vette. It was after charged discussion that we made the design choice to make
rho
aReal
as opposed to a potentially varying material property. We made this choice to actually ensure that users didn't accidentally try to model a compressible problem with incompressible equations. If you actually want to model a compressible problem, I wouldn't recommend trying to work with the INSFV implementation; I would wait instead for the coming CNSFV/PCNSFV work or work off the gitlab fork I've shared with you if you want to get started now. I'm actually quite excited for the CNSFV work where we naturally have on-diagonals in the continuity equation and consequently don't have to use a Rhie…