Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nio Files/Paths #96

Open
t-ober opened this issue Sep 29, 2022 · 3 comments
Open

Use nio Files/Paths #96

t-ober opened this issue Sep 29, 2022 · 3 comments

Comments

@t-ober
Copy link
Contributor

t-ober commented Sep 29, 2022

    I think it could make sense to work with `File`s here, as you can extend them like this: `File file2 = new File(file1, "subdir");`. This would also add type safety (files are recognizable by type, as they're not just represented by Strings). I'd suggest opening a new issue for this

Originally posted by @sebastian-peter in #79 (comment)

@sebastian-peter sebastian-peter changed the title Use File class in PathsAndSources Use nio Files/Paths class in PathsAndSources Sep 30, 2022
@sebastian-peter sebastian-peter changed the title Use nio Files/Paths class in PathsAndSources Use nio Files/Paths Sep 30, 2022
@sebastian-peter
Copy link
Member

I adapted PathsAndSources to use nio Files/Paths in #75. These are preferable over using legacy java.io.File. There are some spots in this project left where Strings are still used and could also be replaced by paths.

@t-ober
Copy link
Contributor Author

t-ober commented Oct 7, 2022

Resolved by #75

@t-ober t-ober closed this as completed Oct 7, 2022
@sebastian-peter
Copy link
Member

As I said in the previous comment, there's many places where we still use Strings and/or java.io.File, so this is not solved imho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants