Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt geo position of nodes to meet electrical line length #9

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

Adapt geo position of nodes to meet electrical line length #9

wants to merge 13 commits into from

Conversation

ckittl
Copy link
Member

@ckittl ckittl commented Nov 19, 2020

Resolves #8

@ckittl ckittl added the enhancement New feature or request label Nov 19, 2020
@ckittl ckittl self-assigned this Nov 19, 2020
@codecov
Copy link

codecov bot commented Nov 19, 2020 •
edited
Loading

Codecov Report

Merging #9 (dca2836) into master (deca85d) will increase coverage by 5.39%.
The diff coverage is n/a.

❗ Current head dca2836 differs from pull request most recent head 97063ba. Consider uploading reports for the commit 97063ba to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master       #9      +/-   ##
============================================
+ Coverage     21.10%   26.50%   +5.39%     
- Complexity       62       84      +22     
============================================
  Files            56       56              
  Lines          1895     2132     +237     
  Branches         72       80       +8     
============================================
+ Hits            400      565     +165     
- Misses         1482     1549      +67     
- Partials         13       18       +5
Impacted Files Coverage Δ
...va/edu/ie3/netpad/tool/controller/ToolDialogs.java 0.00% <0.00%> (ø)
...ie3/netpad/tool/grid/LineLengthResolutionMode.java
...java/edu/ie3/netpad/tool/grid/LineLengthFixer.java
.../edu/ie3/netpad/tool/LineLengthResolutionMode.java 0.00% <0.00%> (ø)
...e3/netpad/exception/GridManipulationException.java 0.00% <0.00%> (ø)
...edu/ie3/netpad/grid/controller/GridController.java 58.47% <0.00%> (+19.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deca85d...97063ba. Read the comment docs.

@ckittl
Copy link
Member Author

ckittl commented Dec 12, 2020

Is blocked by #10.

@ckittl ckittl mentioned this pull request Dec 12, 2020
Merged
@ckittl ckittl changed the title Offer a tool to heal discrepancy between geographical and electrical length of a line Adapt geo position of nodes to meet electrical line length Dec 14, 2020
@ckittl
Copy link
Member Author

ckittl commented Dec 14, 2020

Should be reviewed after #10.

@ckittl ckittl marked this pull request as ready for review October 19, 2021 12:05
@ckittl ckittl requested a review from a team October 19, 2021 12:05
@ckittl ckittl marked this pull request as draft October 19, 2021 12:31
@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
5 similar comments
@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks SonarQubeGithubPRChecks

This comment has been minimized.

Sign in to view
29 similar comments
@sonarqubegithubprchecks SonarQubeGithubPRChecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks SonarQubeGithubPRChecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks SonarQubeGithubPRChecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks SonarQubeGithubPRChecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks SonarQubeGithubPRChecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks SonarQubeGithubPRChecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks SonarQubeGithubPRChecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks SonarQubeGithubPRChecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks SonarQubeGithubPRChecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks SonarQubeGithubPRChecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks SonarQubeGithubPRChecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks SonarQubeGithubPRChecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks SonarQubeGithubPRChecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks SonarQubeGithubPRChecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks SonarQubeGithubPRChecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks SonarQubeGithubPRChecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks SonarQubeGithubPRChecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks SonarQubeGithubPRChecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks SonarQubeGithubPRChecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks SonarQubeGithubPRChecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks SonarQubeGithubPRChecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks SonarQubeGithubPRChecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks SonarQubeGithubPRChecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks SonarQubeGithubPRChecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks SonarQubeGithubPRChecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks SonarQubeGithubPRChecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks SonarQubeGithubPRChecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks SonarQubeGithubPRChecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks SonarQubeGithubPRChecks
Copy link

Failed

  • 12.31% Duplicated Lines (%) on New Code (is greater than 5.00%)

Analysis Details

21 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 21 Code Smells

Coverage and Duplications

  • Coverage No coverage information (26.80% Estimated after merge)
  • Duplications 12.31% Duplicated Code (2.70% Estimated after merge)

Project ID: edu.ie3:NetPadPlusPlus

View in SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ckittl ckittl

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Heal discrepancy between geographical and electrical line length
1 participant
@ckittl