Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup gradle.properties when spotless is fixed for java 17 #200

Open
johanneshiry opened this issue Jan 4, 2022 · 0 comments
Open

Cleanup gradle.properties when spotless is fixed for java 17 #200

johanneshiry opened this issue Jan 4, 2022 · 0 comments
Labels
dependencies Pull requests that update a dependency file invalid This doesn't seem right

Comments

@johanneshiry
Copy link
Member

There is a known bug in spotless (described here diffplug/spotless#834) which prevents out of the box support for spotless. Therefore we make use of the workaround described here (https://github.com/diffplug/spotless/tree/main/plugin-gradle#google-java-format).

As soon as the issue with spotless is resolved, we should cleanup the gradle.properties again.
@johanneshiry johanneshiry added invalid This doesn't seem right dependencies Pull requests that update a dependency file labels Jan 4, 2022
This was referenced Jan 4, 2022
Closed
Closed
Closed
@sebastian-peter sebastian-peter mentioned this issue Apr 1, 2022
Open
This was referenced Jul 21, 2022
Merged
Open
danielfeismann added a commit that referenced this issue Jul 22, 2022
@danielfeismann
Merge pull request #281 from ie3-institute/sp/#200-remove-spotless-wo…
c41ca86 
…rkaround

Remove workaround for spotless google-java-format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johanneshiry