Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register all custom quantity units in PowerSystemUnits #280

Open
sebastian-peter opened this issue Jul 21, 2022 · 0 comments · May be fixed by #282
Open

Register all custom quantity units in PowerSystemUnits #280

sebastian-peter opened this issue Jul 21, 2022 · 0 comments · May be fixed by #282
Labels
bug Something isn't working

Comments

@sebastian-peter
Copy link
Member

Currently, not all units (such as VARHOUR) are registered by using PowerSystemUnits#addUnit. This means that executing Quantities.getQuantity("1 varh") fails. Investigate whether this applies to more unit (compositions).

Furthermore, after the issue has been fixed, enhance PowerSystemUnitsTest to also check quantity parsing with all custom units.
@sebastian-peter sebastian-peter added the bug Something isn't working label Jul 21, 2022
@danielfeismann danielfeismann linked a pull request Jul 22, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Register missing units to addUnit ie3-institute/PowerSystemUtils
1 participant
@sebastian-peter