Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use local files instead of download. #257

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

staudtMarius
Copy link
Member

Resolves #256

@staudtMarius staudtMarius self-assigned this Aug 7, 2024
@staudtMarius staudtMarius marked this pull request as ready for review August 8, 2024 11:44
@staudtMarius staudtMarius added the enhancement New feature or request label Aug 8, 2024
@jo-bao
Copy link
Contributor

jo-bao commented Aug 15, 2024

!test

Copy link
Contributor

@jo-bao jo-bao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me at all! Just some remarks.
But @sebastian-peter has some other comments?

input/config/localFileSourceConfig.conf Outdated Show resolved Hide resolved
src/main/scala/edu/ie3/simbench/main/SimbenchHelper.scala Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to use local files instaed of downloading
2 participants